Log enhancement: return error message when getting assignment servers and log exception when initializing#64
Conversation
…ver assignments from coordinator
|
Is this pr a compatible improvement? |
| this.coordinatorConf = coordinatorConf; | ||
| initialization(); | ||
|
|
||
| try { |
There was a problem hiding this comment.
Why do we need this change?
There was a problem hiding this comment.
I hope all initializing exception message can be recorded into log files. Sometimes due to abnormal configuration, server or coordinator will exit directly no any log recorded, which is hard to debug.
There was a problem hiding this comment.
There will be error msg in the stdout file when the server occur exception. But it's also acceptable change.
There was a problem hiding this comment.
Yes. stdout message will lost when using ansible to deploy uniffle cluster.
I think it's a compatible chang. |
Could you test the compatibility? Maybe we need auto compatibility test in our project. |
|
Tested, it's OK @jerqi |
2 participants
What changes were proposed in this pull request?
Log enhancement: return error message when getting assignment servers and log exception when initializing
Why are the changes needed?
To be easy to find the cause of error.
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need.